Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpMethod option #7

Merged
merged 6 commits into from
May 22, 2022
Merged

HttpMethod option #7

merged 6 commits into from
May 22, 2022

Conversation

oniboni
Copy link
Collaborator

@oniboni oniboni commented Mar 1, 2022

Solves #2

oniboni added 2 commits March 1, 2022 16:16
@oniboni
Adds HttpMethod option.
22aad10 
* `urllib` -> `requests`
* refactoring:
   * -> config.KrokiDiagramTypes
   * -> client.KrokiClient
@oniboni
fix image root path
79cf8ec
@oniboni oniboni mentioned this pull request Mar 2, 2022
Closed
@b-bittner
Copy link
Contributor

Thanks for the PR and sorry for being so lacy the last few weeks.
I just startet testing the changes and it seems to be broken when just setting the httpMethod to POST (without enabling download). It would be nice to have an error message and falling back to GET.

@oniboni
Fallback to GET if POST can't download images.
83ca1b6 
* POST without `DownloadImages` does not work
* GET uris fixed
@oniboni
Copy link
Collaborator Author

oniboni commented Apr 24, 2022

Hi,
I could reproduce the problem and fixed my errors.

Does it work for you now?

@b-bittner b-bittner merged commit be1de0f into AVATEAM-IT-SYSTEMHAUS:main May 22, 2022
@b-bittner b-bittner mentioned this pull request May 22, 2022
Closed
@oniboni oniboni deleted the feature/POST_option branch October 13, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oniboni @b-bittner